feat: toggle avt test #14449
Merged
feat: toggle avt test #14449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abelledby
…rdona/carbon into 14331-toggle-avt-tests
guidari
reviewed
Aug 21, 2023
guidari
reviewed
Aug 21, 2023
Co-authored-by: Guilherme Datilio Ribeiro <guilhermedatilio@gmail.com>
abelledby
Co-authored-by: Guilherme Datilio Ribeiro <guilhermedatilio@gmail.com>
8960d95 to
6e43ffa
Compare
…rdona/carbon into 14331-toggle-avt-tests
alisonjoseph
approved these changes
Aug 23, 2023
guidari
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13747
Closes #14331
Changelog
New
Broke https://github.com/AVT tests out into their own Tabs-test.avt.e2e.js file
@vrt tests remain in the Tabs-test.e2e.js file
Add keyboard navigation tests covering default Tabs state
Update playwright config glob to match and include the new test file naming structure (avt.e2e.js)
Testing / Reviewing
CI should pass
Ensure the tests pass a sniff test and don't look problematic
yarn playwright test components/Toggle/Toggle-test.avt.e2e.js