-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(datatable): add @avt tests #14357
test(datatable): add @avt tests #14357
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tay1orjones should we include some basic keyboard navigation tests here as well? Can probably capture most of them in the |
@tw15egan Good call, I just pushed up a big block of keyboard nav related tests. This PR also now updates to the latest version of playwright so that we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had a few comments that can be addressed separate to this PR
Closes #14118
Changelog
New
Changed
Testing / Reviewing