Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): persist onChange for React 16 #14249

Merged

Conversation

tay1orjones
Copy link
Member

Reported in slack

Changelog

Changed

  • call evt.persist() in the onchange to ensure it is not removed prematurely in react 16

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 04664e9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b945948db9da0008e4431d
😎 Deploy Preview https://deploy-preview-14249--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 04664e9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b94594e1db120008c92ab9
😎 Deploy Preview https://deploy-preview-14249--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read the thread in slack! LGTM!

@andreancardona andreancardona enabled auto-merge July 20, 2023 14:58
@andreancardona andreancardona added this pull request to the merge queue Jul 20, 2023
Merged via the queue into carbon-design-system:main with commit eac9de1 Jul 20, 2023
@carbon-automation
Copy link
Contributor

Hey there! v11.34.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants