Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): update-carbon-icons-react-import-to-carbon-react codemod #14217

Conversation

tay1orjones
Copy link
Member

This introduces a new codemod that will automatically convert imports from @carbon/icons-react to @carbon/react/icons.

This spawned from #14014 w/ @sstrubberg

Changelog

New

  • Added update-carbon-icons-react-import-to-carbon-react codemod and associated tests and test fixtures.

Changed

  • Updated v11.md to list this codemod and reorganize some of the content so that it's clear you need to run this one after the icon size prop codemod

Testing / Reviewing

  • Ensure the input/output test fixtures make sense - input is what someones code should look like before running the codemod, and the output is what we expect the codemod to generate/change it to.
  • Make sure the docs read well and I didn't miss anything

@tay1orjones tay1orjones requested a review from a team as a code owner July 13, 2023 19:49
@tay1orjones tay1orjones self-assigned this Jul 13, 2023
@tay1orjones tay1orjones added this to the 2023 Q3 milestone Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit aea4dee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b15ecb128ccc0008824a50
😎 Deploy Preview https://deploy-preview-14217--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit aea4dee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b15ecb083be30008daebbc
😎 Deploy Preview https://deploy-preview-14217--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tay1orjones tay1orjones merged commit e0382e6 into carbon-design-system:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants