Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): fix a11y issues with selection variant #14206

Merged

Conversation

tw15egan
Copy link
Collaborator

Closes #14053

Fixes an issue where an aria-label was placed on a label with no role. Since no valid roles are available, I've moved the text from an aria-label to be placed inside the label and visually hidden.

Changelog

Changed

  • removed aria-label, use aria-label to generate label text and hide it

Testing / Reviewing

Go to DataTable w Selection story and run the a11y checker. Ensure there are no more violations and the functionality remains the same.

@tw15egan tw15egan requested a review from a team as a code owner July 13, 2023 14:51
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3321005
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b05ccd0ba4c7000742424e
😎 Deploy Preview https://deploy-preview-14206--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3321005
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b05ccd66aafd0008cdc7a9
😎 Deploy Preview https://deploy-preview-14206--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with VO and looks good!

@kodiakhq kodiakhq bot merged commit a410069 into carbon-design-system:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: DataTable [selection] - "aria-label" is not valid for the element <label>
3 participants