Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): update devtools toolbar for storybook 7 #14179

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

janhassel
Copy link
Member

With the update to Storybook 7, the items in the development version of the storybook aren't rendering properly anymore due to API changes.
image

This PR updates the dev toolbar items to use the storybook 7 API.

Testing / Reviewing

In the development version of the react storybook, the two items "unstable__Layout size" and "unstable__Layout density" should appear correctly.
image

As before, in the built storybook these items should remain hidden.

@janhassel janhassel requested a review from a team as a code owner July 11, 2023 08:04
@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f23cfbb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64ad87f15e10d600082ce718
😎 Deploy Preview https://deploy-preview-14179--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f23cfbb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ad87f118d77c000812976c
😎 Deploy Preview https://deploy-preview-14179--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kodiakhq kodiakhq bot merged commit a72388e into carbon-design-system:main Jul 11, 2023
@janhassel janhassel deleted the storybook7-toolbar-fix branch July 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants