Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): update to latest ruleset #14171

Merged
merged 6 commits into from
Jul 13, 2023
Merged

chore(a11y): update to latest ruleset #14171

merged 6 commits into from
Jul 13, 2023

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Jul 10, 2023 •
edited
Loading

Closes #14135

Changelog

New

  • Adds MDX docs for Form & FluidForm
  • Adds A11y considerations section including Accessible Naming guide for Form, FluidForm & DataTable docs

Changed

Testing / Reviewing

avt should pass, ensure added a11y guidance looks correct

@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9ce31a0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b00b9533d4a100079df094
😎 Deploy Preview https://deploy-preview-14171--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ce31a0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b00b957e6a9b00087261aa
😎 Deploy Preview https://deploy-preview-14171--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@francinelucca francinelucca marked this pull request as ready for review July 11, 2023 20:29
@francinelucca francinelucca requested a review from a team as a code owner July 11, 2023 20:29
tay1orjones
tay1orjones approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

tw15egan
tw15egan approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for doing this! 💪🏻 🎉

@kodiakhq kodiakhq bot merged commit 1ccdb5c into carbon-design-system:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update a11y-checker ruleset to 1July2023
3 participants
@francinelucca @tay1orjones @tw15egan