Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ComboButton): import IconButton before Button #14155

Merged

Conversation

francinelucca
Copy link
Collaborator

Fixes for broken ComboButton story.

Changelog

Changed

  • Put Button import under IconButton import in ComboButton's index file

Testing / Reviewing

Make sure ComboButton stories are able to render in preview

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 100c989
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a84cb810fe3d00083b61bc
😎 Deploy Preview https://deploy-preview-14155--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 100c989
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a84cb89760a60008712150
😎 Deploy Preview https://deploy-preview-14155--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodiakhq kodiakhq bot merged commit f63a688 into carbon-design-system:main Jul 7, 2023
tay1orjones pushed a commit to tay1orjones/carbon that referenced this pull request Jul 7, 2023
…em#14155)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants