Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): fix undefined prefix #13853

Merged
merged 2 commits into from
May 25, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #13841

Fixes an issue that was causing the classname to append undefined as a prefix

Changelog

Changed

  • Updated function signature so that is pulls prefix from usePrefix

Testing / Reviewing

Open a range calendar, right-click on a day, and ensure the classname is applied correctly (cds--date-picker__day)

@tw15egan tw15egan requested a review from a team as a code owner May 22, 2023 17:51
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c07bf5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/646eb0df4608fa0008e7386d
😎 Deploy Preview https://deploy-preview-13853--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3c07bf5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/646eb0dfc833840008f55a0b
😎 Deploy Preview https://deploy-preview-13853--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified day has the class 😎

@kodiakhq kodiakhq bot merged commit e0fbf83 into carbon-design-system:main May 25, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.30.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Prefix is undefined in DatePicker.js
4 participants