Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): use vite 4.x #13848

Merged
merged 3 commits into from
May 22, 2023

Conversation

falsepopsky
Copy link
Contributor

@falsepopsky falsepopsky commented May 22, 2023

Closes #13683

Changelog

Changed

  • Updated deps @vitejs/plugin-react & vite to latest.
  • use createRoot for React examples.

Testing / Reviewing

CI should pass

@falsepopsky falsepopsky requested a review from a team as a code owner May 22, 2023 00:56
@falsepopsky falsepopsky changed the title Update vite feat(examples): use vite 4.x May 22, 2023
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f7e5a4c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/646b7fb7d454d30008924d3f
😎 Deploy Preview https://deploy-preview-13848--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f7e5a4c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/646b7fb7134c040008a8973b
😎 Deploy Preview https://deploy-preview-13848--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, thanks for taking this on 👍🏻 ✅

@kodiakhq kodiakhq bot merged commit 08f4d69 into carbon-design-system:main May 22, 2023
@falsepopsky falsepopsky deleted the update-vite branch May 22, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use Vite 4.x
3 participants