Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(achecker): update accessibility-checker ruleset #13840

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 19, 2023

Closes #13742

Changelog

Changed

  • update accessibility-checker version
  • update accessibility-checker ruleset to track latest instead of a specific release
  • update accessibility-checker config and denylist for both e2e tests and jest-config-carbon
  • update unique id for contentswitcher icon only avt test

Removed

  • remove unecessary aria-labelledby in modal
  • remove outdated and unnecessary tests from jest unit tests

Testing / Reviewing

  • CI should pass

⚠️ The 'aria_child_tabbable' entry in the denylist should be removed as part of #13678

@tay1orjones tay1orjones self-assigned this May 19, 2023
@tay1orjones tay1orjones added type: a11y ♿ role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels May 19, 2023
@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0f063f5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/646f6acd9251510007ee5d4a
😎 Deploy Preview https://deploy-preview-13840--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0f063f5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/646f6acd7ab464000992fa45
😎 Deploy Preview https://deploy-preview-13840--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones marked this pull request as ready for review May 24, 2023 15:11
@tay1orjones tay1orjones requested a review from a team as a code owner May 24, 2023 15:11
@tay1orjones tay1orjones mentioned this pull request May 24, 2023
22 tasks
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅ 🎉

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 yahoo!!

@kodiakhq kodiakhq bot merged commit b016d02 into carbon-design-system:main May 25, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.30.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[a11y]: Modal sets aria-labelled-by but Accessibility Checker complains
5 participants