Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(menu): move to stable #13678

Merged
merged 23 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6a94f3f
chore(menu): update copyright banners
janhassel Apr 27, 2023
f186335
chore(menu): remove unstable__ prefix from exports
janhassel Apr 27, 2023
2053fd0
chore(menu): update copyright banners
janhassel Apr 27, 2023
98972ea
chore(menu): move to stable stories
janhassel Apr 27, 2023
9214ce9
test(overflow-menu-v2): add vrt and avt
janhassel Apr 27, 2023
d16c8f1
fix(menu-item): move default prop function out
janhassel Apr 27, 2023
05f8bc4
docs(overflow-menu-v2): add mdx
janhassel Apr 27, 2023
5c7d86b
fix(combo-button): sync tooltipAlignment prop naming
janhassel Apr 27, 2023
53d3421
feat(overflow-menu-v2): add props.label and props.tooltipAlignment
janhassel Apr 27, 2023
9c81526
fix(overflow-menu-v2): fix a11y violation with aria-owns
janhassel Apr 27, 2023
31fc557
Merge branch 'main' into 13514
janhassel May 19, 2023
e4f61e9
refactor(overflowmenu): expose next overflowmenu under feature flag
janhassel May 19, 2023
b0bf3ad
fix(overflowmenu): add back explicit displayName
janhassel May 22, 2023
5b1e2f7
fix: add aria-controls, move aria-owns to parent container
janhassel May 24, 2023
3200614
Merge branch 'main' into 13514
janhassel May 24, 2023
b2ea7bc
Merge branch 'main' into 13514
janhassel May 24, 2023
b33919f
fix(menu): vertically center-align nesting caret
janhassel May 25, 2023
2cadfbc
Merge branch 'main' into 13514
tay1orjones May 25, 2023
196f0dd
ci: remove aria_child_tabbable from testing denylists
janhassel Jun 1, 2023
0a84241
Merge branch 'main' into 13514
janhassel Jun 5, 2023
e2a06cf
test: re-add aria_child_tabbable to AC denylist
tay1orjones Jun 6, 2023
e8f76b4
Merge branch 'main' into 13514
tay1orjones Jun 6, 2023
7fa11d3
Merge branch 'main' into 13514
kodiakhq[bot] Jun 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/components/ComboButton/ComboButton-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test.describe('ComboButton', () => {
test('combo-button @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'ComboButton',
id: 'experimental-unstable-combobutton--default',
id: 'components-combobutton--default',
theme,
});
});
Expand All @@ -27,7 +27,7 @@ test.describe('ComboButton', () => {
test('accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'ComboButton',
id: 'experimental-unstable-combobutton--default',
id: 'components-combobutton--default',
globals: {
theme: 'white',
},
Expand Down
4 changes: 2 additions & 2 deletions e2e/components/Menu/Menu-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test.describe('Menu', () => {
test('menu @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'Menu',
id: 'experimental-unstable-menu--playground',
id: 'components-menu--playground',
theme,
});
});
Expand All @@ -27,7 +27,7 @@ test.describe('Menu', () => {
test('accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'Menu',
id: 'experimental-unstable-menu--playground',
id: 'components-menu--playground',
globals: {
theme: 'white',
},
Expand Down
4 changes: 2 additions & 2 deletions e2e/components/MenuButton/MenuButton-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test.describe('MenuButton', () => {
test('menu-button @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'MenuButton',
id: 'experimental-unstable-menubutton--default',
id: 'components-menubutton--default',
theme,
});
});
Expand All @@ -27,7 +27,7 @@ test.describe('MenuButton', () => {
test('accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'experimental-unstable-menubutton--default',
id: 'components-menubutton--default',
globals: {
theme: 'white',
},
Expand Down
27 changes: 27 additions & 0 deletions e2e/components/OverflowMenu/OverflowMenu-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ test.describe('OverflowMenu', () => {
theme,
});
});

test('feature flags default @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'OverflowMenu',
id: 'experimental-feature-flags-overflowmenu--overflow-menu',
theme,
});
});

test('feature flags render custom icon @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'OverflowMenu',
id: 'experimental-feature-flags-overflowmenu--custom-icon',
theme,
});
});
});
});

Expand All @@ -42,4 +58,15 @@ test.describe('OverflowMenu', () => {
});
await expect(page).toHaveNoACViolations('OverflowMenu');
});

test('feature flag accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'OverflowMenu',
id: 'experimental-feature-flags-overflowmenu--overflow-menu',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('OverflowMenu');
});
});
4 changes: 4 additions & 0 deletions packages/feature-flags/feature-flags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ feature-flags:
description: >
Enable rendering of default icons in the tile components
enabled: false
- name: enable-v12-overflowmenu
description: >
Enable the use of the v12 OverflowMenu leveraging the Menu subcomponents
enabled: false
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ $types: (
column-gap: spacing.$spacing-02;
}

.#{$prefix}--annotation__label > :first-child {
flex-shrink: 0;
}

.#{$prefix}--annotation__label a {
color: inherit;
text-decoration: underline;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function WithDeprecationNotice({ children, text }) {
type="deprecation-notice"
text={
<div>
Deprecation notice
<strong>Deprecation notice</strong>
<br />
{text}
</div>
Expand Down
Loading