Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed placeholder from dropdown/downshift storybook examples #13509

Merged
merged 3 commits into from
Apr 13, 2023
Merged

fix: removed placeholder from dropdown/downshift storybook examples #13509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6a8d9
fix: removed placeholder from dropdown/downshift storybook examples
guidari Apr 11, 2023
9cf033d
Merge branch 'main' into 13122-placeholder-dropdown-fix
francinelucca Apr 12, 2023
2a77959
Merge branch 'main' into 13122-placeholder-dropdown-fix
kodiakhq[bot] Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/react/src/components/ComboBox/ComboBox.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export const Default = () => (
},
}}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="ComboBox title"
helperText="Combobox helper text"
/>
Expand All @@ -89,7 +88,6 @@ export const _WithLayer = () => (
id={`carbon-combobox-${layer}`}
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="ComboBox title"
helperText="Combobox helper text"
/>
Expand All @@ -109,7 +107,6 @@ export const Playground = (args) => (
},
}}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="ComboBox title"
helperText="Combobox helper text"
{...args}
Expand Down
4 changes: 0 additions & 4 deletions packages/react/src/components/FluidComboBox/FluidComboBox.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ const ToggleTip = (
export const Default = () => (
<div style={{ width: '400px' }}>
<FluidComboBox
placeholder="Filter..."
onChange={() => {}}
id="default"
titleText="Label"
Expand All @@ -82,7 +81,6 @@ export const Default = () => (
export const Condensed = () => (
<div style={{ width: '400px' }}>
<FluidComboBox
placeholder="Filter..."
onChange={() => {}}
id="default"
isCondensed
Expand All @@ -97,7 +95,6 @@ export const Condensed = () => (
export const Playground = (args) => (
<div style={{ width: args.playgroundWidth }}>
<FluidComboBox
placeholder="Filter..."
onChange={() => {}}
id="default"
titleText="Label"
Expand All @@ -108,7 +105,6 @@ export const Playground = (args) => (
/>
<br />
<FluidComboBox
placeholder="Filter..."
{...args}
onChange={() => {}}
id="default-3"
Expand Down