fix(CopyButton): adjust aria-live, add closeOnActivation #13460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13163
removes the
aria-live
that was causing the voiceover to read the copy text twice. This seems like a holdover from before we usedIconButton
under the hood. SinceIconButton
has proper aria roles and labels, it can handle the voiceover itself.Also noticed an issue where the popover content was being closed immediately upon activation, rendering the
feedback
text uselessTo fix this, I've added the
closeOnActivation
prop as configurable iniconButton
, rather than setting it to always be false. It is passed in asfalse
fromCopy
Changelog
Changed
closeOnActivation
can be configured iniconButton
Removed
aria-live
was removed fromCopyButton
Testing / Reviewing
Ensure there are no a11y violations. Ensure the voiceover only reads the feedback text once.