Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DataTable): add a basic story with two lines of text #13457

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Apr 3, 2023

Closes #6382

Adds an example of how to properly style two lines of text in one row of the DataTable

Changelog

New

  • A new story under the basic folder that shows the XL variant of table with two lines of text in one row

Testing / Reviewing

Go to DataTable/Basic/XL With Two Lines and ensure it renders correctly

@tw15egan tw15egan requested a review from a team as a code owner April 3, 2023 12:07
@tw15egan tw15egan requested review from a team and laurenmrice and removed request for a team April 3, 2023 12:08
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 1c20825
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/642ac16b65c6e900085fe438
😎 Deploy Preview https://deploy-preview-13457--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1c20825
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/642ac16bd036630007467d76
😎 Deploy Preview https://deploy-preview-13457--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit abad41e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/642d4adcc3e1e400082c7747
😎 Deploy Preview https://deploy-preview-13457--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit abad41e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/642d4adc987d380008835265
😎 Deploy Preview https://deploy-preview-13457--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅

@kodiakhq kodiakhq bot merged commit 298036a into carbon-design-system:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data table] show two lines of text in a row
4 participants