-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move ToggleSkeleton to TypeScript #13451
refactor: move ToggleSkeleton to TypeScript #13451
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ran on main branch and confirmed broken styling: Opened up new issue #13459. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, we can handle the visual bug and adding to storybook in a separate issue/PR 😄
@gerzonc looks like there is a small merge conflict in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gerzonc thanks for adding this, looks good! 🚀
After you solve the Readme.md
merge conflicts and this should be good to go 🙏🏻
Closes #12565
Migrates
ToggleSkeleton
to TypeScriptChangelog
New
ToggleSkeletonProps
forToggleSkeleton
defaultProps
Changed
ToggleSkeleton
is now a TypeScript filearia-label
now checks forundefined
instead ofnull
if there is alabelText
presentRemoved
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}