refactor(Button): padding units from pixel to rem #13407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10318
Change remaining
px
units inButton
padding torem
Changelog
New
Changed
Removed
Testing / Reviewing
rem
rem
calculations still have the same desired size outcome as before. Below are some Dev Tool images of the original button sizes before this update for comparison.sm
md
lg
xl
2xl
Secondary
buttons inButton.stories.js
to manually inspect the values persize
.