feat: add eslint-plugin-jest-dom #13392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as outdated.
This comment was marked as outdated.
falsepopsky
commented
Mar 23, 2023
This comment was marked as outdated.
This comment was marked as outdated.
95a71c5 to
f5f24c3
Compare
tay1orjones
requested changes
Mar 29, 2023
|
Hey @falsepopsky! thanks for the contribution. Curious if you are an IBMer or if you are using Carbon externally for a project. Let us know! |
tay1orjones
approved these changes
Mar 30, 2023
|
Hi!. I'm not an IBMer but I have used Carbon in the past. I mostly use icons or pictograms package. Have a great day! maybe i will take a look at #9048 later |
aledavila
approved these changes
Mar 30, 2023
tw15egan
pushed a commit
to tw15egan/carbon
that referenced
this pull request
Mar 31, 2023
* feat: add eslint-plugin-jest-dom * fix: eslint errors * fix(rebase): eslint, tests * fix: lint jest-dom config only test files --------- Co-authored-by: Alessandra Davila <adavila91@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
tw15egan
pushed a commit
to tw15egan/carbon
that referenced
this pull request
Mar 31, 2023
* feat: add eslint-plugin-jest-dom * fix: eslint errors * fix(rebase): eslint, tests * fix: lint jest-dom config only test files --------- Co-authored-by: Alessandra Davila <adavila91@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13312
I added the dependency
eslint-plugin-jest-domand enabled the recommended configuration by default. I also fixed a ton of errors resulting from this change.Changelog
New
Changed
Removed
Testing / Reviewing
Make sure there are no errors when running lint, and that the tests pass successfully.