Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ExpandableTile): support forward ref #13390

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

pratikkarad
Copy link
Contributor

Closes #13340

Changelog

Changed

  • Used existing ref to support the forward ref

@pratikkarad pratikkarad requested a review from a team as a code owner March 22, 2023 07:37
@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4034d1a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6425f6682397b30008c24da9
😎 Deploy Preview https://deploy-preview-13390--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4034d1a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6425f668277f1000081b6fe2
😎 Deploy Preview https://deploy-preview-13390--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/react/src/components/Tile/Tile.js Outdated Show resolved Hide resolved
@pratikkarad pratikkarad requested a review from a team as a code owner March 23, 2023 18:10
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledavila
Copy link
Contributor

@tay1orjones oh you have changes requested hold on this

@francinelucca francinelucca dismissed tay1orjones’s stale review March 30, 2023 20:51

Comment has been resolved

@kodiakhq kodiakhq bot merged commit eb615ba into carbon-design-system:main Mar 30, 2023
@pratikkarad pratikkarad deleted the expandabletile-13340 branch March 31, 2023 03:44
tw15egan pushed a commit to tw15egan/carbon that referenced this pull request Mar 31, 2023
* fix(ExpandableTile): support forward ref

* fix(ExpandableTile): use useMergedRefs hook

* fix(ExpandableTile): update PublicAPI test

---------

Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ExpandableTile does not forward a ref
4 participants