Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioTile): positioning bug when grid aligned #13381

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Mar 21, 2023

Closes #13046

Changelog

New

  • add wrapper div around each radio tile input/label

Testing / Reviewing

Ensure that nothing changed with RadioTiles, check demo story to make sure it doesn't jump to top when you select tiles.
https://deploy-preview-13381--carbon-components-react.netlify.app/?path=/story/components-tile--radio-grid-demo

DON'T MERGE UNTIL DEMO FILES ARE DELETED

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84d61fe
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6435a49e8bf3a2000897c112
😎 Deploy Preview https://deploy-preview-13381--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 84d61fe
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6435a49e27810f0008f7d176
😎 Deploy Preview https://deploy-preview-13381--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones requested review from francinelucca and removed request for aledavila April 10, 2023 23:59
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple tests failing though

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm no scroll on bottom tiles, if I scroll all the way down and click on the mid tiles I still get scrolled up, is that expected?

Screen.Recording.2023-04-11.at.2.00.30.PM.mov

@alisonjoseph
Copy link
Member Author

@francinelucca I think its just scrolling up to the one you clicked on correct? If so, that's expected.

@kodiakhq kodiakhq bot merged commit 8fefe14 into carbon-design-system:main Apr 11, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.27.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TileGroup scrolls to top when RadioTile is clicked in grid layout
4 participants