-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RadioTile): positioning bug when grid aligned #13381
fix(RadioTile): positioning bug when grid aligned #13381
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple tests failing though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm no scroll on bottom tiles, if I scroll all the way down and click on the mid tiles I still get scrolled up, is that expected?
Screen.Recording.2023-04-11.at.2.00.30.PM.mov
@francinelucca I think its just scrolling up to the one you clicked on correct? If so, that's expected. |
Hey there! v11.27.0 was just released that references this issue/PR. |
Closes #13046
Changelog
New
Testing / Reviewing
Ensure that nothing changed with RadioTiles, check demo story to make sure it doesn't jump to top when you select tiles.
https://deploy-preview-13381--carbon-components-react.netlify.app/?path=/story/components-tile--radio-grid-demo
DON'T MERGE UNTIL DEMO FILES ARE DELETED