Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toggletip): general a11y / ux improvements #13112

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 7, 2023

Closes #12922

Addresses general UX / a11y issues found in the Toggletip component

Changelog

New

  • Toggletip will now close when the menu is tabbed through, and focus leaves the popover body.
  • If Escape is pressed while an item inside the Toggletip is focused, the focus will return to the Toggletip trigger

Changed

  • Updated ToggletipLabel to body-01 to match the design specs
  • Labelled the stories better to note that Toggletip is not normally rendered open by default

Testing / Reviewing

  • Open the Toggletip story
  • Tab through the component. Focus should go to the trigger, then press Space to open the menu. Tab through the component, and the menu should close when the focus leaves the popover body.
  • Tab through the component. While an item inside has focus (not the trigger), hit the Escape key. The focus should return to the trigger.
  • Ensure all existing functionality remains

@tw15egan tw15egan requested a review from a team as a code owner February 7, 2023 18:16
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a7eb812
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63e3f25276aeb30007cb0f81
😎 Deploy Preview https://deploy-preview-13112--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a7eb812
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63e3f252d3c8530008b4dd6b
😎 Deploy Preview https://deploy-preview-13112--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm works as expected !

@kodiakhq kodiakhq bot merged commit e328f22 into carbon-design-system:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: toggletip implementation bugs
3 participants