Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(clicklistener): update tests to rtl #13111

Merged
merged 3 commits into from
Feb 8, 2023
Merged

test(clicklistener): update tests to rtl #13111

merged 3 commits into from
Feb 8, 2023

Conversation

alisonjoseph
Copy link
Member

Closes #12686

Updates tests to RTL

Testing / Reviewing

yarn test packages/react/src/internal/__tests__/ClickListener-test.js

Screenshot 2023-02-07 at 9 56 23 AM

@alisonjoseph alisonjoseph marked this pull request as ready for review February 7, 2023 15:57
@alisonjoseph alisonjoseph requested a review from a team as a code owner February 7, 2023 15:57
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5df6d3b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63e3f8bde8f15100080a306d
😎 Deploy Preview https://deploy-preview-13111--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5df6d3b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63e3f8bdf74ff50007a4e567
😎 Deploy Preview https://deploy-preview-13111--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and all looks good!

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 6dc7b13 into carbon-design-system:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in internal ClickListener-test.js
3 participants