Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elements-colors): update colors preview #13066

Merged
merged 7 commits into from
Feb 9, 2023
Merged

feat(elements-colors): update colors preview #13066

merged 7 commits into from
Feb 9, 2023

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Jan 31, 2023 •
edited
Loading

Closes #12466

Updates colors elements preview to use next.js

Testing / Reviewing

Make sure Colors preview is working and shows as before.

@aledavila aledavila requested a review from a team as a code owner January 31, 2023 21:40
@netlify
Copy link

netlify bot commented Jan 31, 2023

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 8a67883
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63d98ae7a5ceb300081cc050
😎 Deploy Preview https://deploy-preview-13066--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 31, 2023

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8a67883
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63d98ae79bcba400088727ab
😎 Deploy Preview https://deploy-preview-13066--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 75eabd7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63e4f735906cb9000794b87a
😎 Deploy Preview https://deploy-preview-13066--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 75eabd7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63e4f736e6b992000836ed85
😎 Deploy Preview https://deploy-preview-13066--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

francinelucca
francinelucca reviewed Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I see one minor difference in the headers, is that ok?
image
image

@kodiakhq kodiakhq bot merged commit 64d1c96 into carbon-design-system:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca left review comments

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update @carbon/colors elements preview to v11
5 participants
@aledavila @alisonjoseph @tay1orjones @francinelucca @tw15egan