Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(DataTableSkeleton): update tests to RTL #13052

Merged

Conversation

tw15egan
Copy link
Collaborator

Closes #12675

Updates and expands DataTableSkeleton test coverage

Changelog

New

  • New tests using RTL that should test each prop and basic functionality.

Changed

  • Fixed some minor issues with the DataTableSkeleton story

Removed

  • Old test file

Testing / Reviewing

Ensure the tests cover each prop, and that all behavior tests are covered

@tw15egan tw15egan requested a review from a team as a code owner January 30, 2023 18:49
@tw15egan tw15egan force-pushed the data-table-skeleton-rtl branch from 6fe9c5b to dfb707c Compare January 30, 2023 18:50
@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 6fe9c5b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63d81142c3d1c9000812ab63
😎 Deploy Preview https://deploy-preview-13052--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6fe9c5b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63d81142155fd60008f868ab
😎 Deploy Preview https://deploy-preview-13052--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 40f2220
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63e26b72b03e560008ba36a8
😎 Deploy Preview https://deploy-preview-13052--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 40f2220
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63e26b72b39d680008d4f20a
😎 Deploy Preview https://deploy-preview-13052--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 super readable! ❤️ it

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 93793b7 into carbon-design-system:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in DataTableSkeleton/DataTableSkeleton-test.js
3 participants