-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): ensure flatpickr instance is crated after lazy input resolves #12969
Merged
kodiakhq
merged 6 commits into
carbon-design-system:main
from
tay1orjones:10692-lazy-datepicker
Jan 12, 2023
Merged
fix(datepicker): ensure flatpickr instance is crated after lazy input resolves #12969
kodiakhq
merged 6 commits into
carbon-design-system:main
from
tay1orjones:10692-lazy-datepicker
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolves > > Co-authored-by: TJ EGAN tw15egan@gmail.com
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
approved these changes
Jan 11, 2023
francinelucca
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 LGTM!
… into 10692-lazy-datepicker
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
DO NOT MERGE
labels
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10692
If the DatePicker was brought in via React.lazy, the
ref
assigned to the start input was not being updated after the component resolved. This caused the flatpickr instance to never be assigned to the input, so the calendar would never show.Changelog
Changed
useCallback
instead ofuseRef
, store the status of the ref in state, and use it to trigger the existinguseEffect
after react.lazy resolvesTesting / Reviewing
simple
datepicker story, it should function normally. I've modified it to use react.lazyDon't merge this PR until we've reverted the story to it's original state.Done