Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CodeSnippet): resolve issue with disabled styles #12953

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #12946

Fixes an issue that caused the Copy Button to be the wrong color when the CodeSnippet was disabled.

Changelog

Changed

  • Added non-hover disabled copy button to the disabled styles block.
  • Updated copy on the playground story

Testing / Reviewing

Go to the playground story for CodeSnippet and set disabled to true; ensure all styles look correct.

@tw15egan tw15egan requested a review from a team as a code owner January 10, 2023 18:08
@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e5af84
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63c94ff0f788bb00089ea9db
😎 Deploy Preview https://deploy-preview-12953--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5e5af84
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63c94ff0f75ca100091c859c
😎 Deploy Preview https://deploy-preview-12953--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 5ebfd52 into carbon-design-system:main Jan 19, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.21.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Code snippet showing background color changing on hover on disabled state
4 participants