Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(eslint): update eslint to error if style prop is used #12924

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jan 5, 2023

Closes #12803

Updates our eslint-config to forbid using the style prop/dom node.

Changelog

New

  • react/forbid-component-props
  • react/forbid-dom-props

Testing / Reviewing

Try adding a style prop and make sure an error appears in your editor.

@tw15egan tw15egan requested a review from a team as a code owner January 5, 2023 15:53
@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ec7d53
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63c860947a35a20009d49cda
😎 Deploy Preview https://deploy-preview-12924--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9ec7d53
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63c86094c6f7b80008ee4918
😎 Deploy Preview https://deploy-preview-12924--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan tw15egan force-pushed the update-eslint-rules branch from 007d419 to f7fcc80 Compare January 5, 2023 17:28
@tw15egan
Copy link
Collaborator Author

cc @aledavila for review

@kodiakhq kodiakhq bot merged commit 899c996 into carbon-design-system:main Jan 18, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.21.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow inline styles via eslint
4 participants