-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(eslint): update eslint to error if style prop is used #12924
Merged
kodiakhq
merged 4 commits into
carbon-design-system:main
from
tw15egan:update-eslint-rules
Jan 18, 2023
Merged
test(eslint): update eslint to error if style prop is used #12924
kodiakhq
merged 4 commits into
carbon-design-system:main
from
tw15egan:update-eslint-rules
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
force-pushed
the
update-eslint-rules
branch
from
January 5, 2023 17:28
007d419
to
f7fcc80
Compare
tay1orjones
approved these changes
Jan 5, 2023
cc @aledavila for review |
aledavila
approved these changes
Jan 18, 2023
Hey there! v11.21.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12803
Updates our
eslint-config
to forbid using thestyle
prop/dom node.Changelog
New
react/forbid-component-props
react/forbid-dom-props
Testing / Reviewing
Try adding a
style
prop and make sure an error appears in your editor.