Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(SecondaryButton): replace Enzyme with RTL #12700

Merged
merged 5 commits into from
Nov 28, 2022
Merged

test(SecondaryButton): replace Enzyme with RTL #12700

merged 5 commits into from
Nov 28, 2022

Conversation

cknabe
Copy link
Contributor

@cknabe cknabe commented Nov 18, 2022

Closes #12157

image

@cknabe cknabe requested a review from a team as a code owner November 18, 2022 17:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@cknabe
Copy link
Contributor Author

cknabe commented Nov 18, 2022

I have read the DCO document and I hereby sign the DCO.

@cknabe
Copy link
Contributor Author

cknabe commented Nov 21, 2022

My initial PR used an approach that RTL does not recommend. I refactored to use screen.getByRole etc.

@kodiakhq kodiakhq bot merged commit 026439e into carbon-design-system:main Nov 28, 2022
@cknabe cknabe mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in SecondaryButton/SecondaryButton-test.js
3 participants
@cknabe @alisonjoseph @tw15egan