Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progress-indicator): add storybook controls #12473

Merged

Conversation

aledavila
Copy link
Contributor

Closes #12227

Testing / Reviewing

Make sure stories are working as intended
Make sure playground controls work as intended

@aledavila aledavila requested a review from a team as a code owner November 3, 2022 05:40
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1fbf5e2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636d5e35d406e70008334b82
😎 Deploy Preview https://deploy-preview-12473--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1fbf5e2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636d5e355f609b00097a8844
😎 Deploy Preview https://deploy-preview-12473--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one suggestion

…tor.stories.js

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 1f0ce2d into carbon-design-system:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: components/ProgressIndicator/next/ProgressIndicator.stories.js
3 participants