-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Modal): add isFullWidth prop #12462
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think they would still be able to do that; they would just have to add padding independently. This just removes any padding we ship to prevent our styles from blocking any designs since we only place padding on the modal body container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks great and thanks for the ⚡ speed. I'm wondering if this creates additional work for @carbon-design-system/carbon-platform-designers to add guidance on when to use the isFullwidth
prop...? This PR looks good to me though! Thank you!
You bring up a good point @shixiedesign we need to add guidance on the website now. It would actually be the system squad who adds it (platform is pulling markdown from the original site atm). I've made an issue so we don't forget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #11933
Adds a new
isFullWIdth
prop that removes any margin and padding placed on themodal-content
class.Changelog
New
isFullWidth
prop and associated styles forModal
andComposedModal
that removes margin and padding.Testing / Reviewing
Was unsure if we also wanted to remove the padding/margin from the headers; for now they are still there because they match the spec images
ComposedModal
andModal
and ensure theFull Width
example matches the spec images.