Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): adds character counter alert #12411

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Oct 27, 2022

Closes #12071

Changelog

  • adds span with role="alert", visually hidden, and only announces on last 10 characters

Testing / Reviewing

  • go to TextArea playground
    • set character counter
    • turn on VO
    • type until you reach the limit, you should see the VO announce the last 10 characters
    • if you delete the last 10 characters, VO character count should be updated
    • any number less than the last 10 should not announce anything
  • all test should pass
  • TextArea should still work as expected

@jnm2377 jnm2377 requested a review from a team as a code owner October 27, 2022 15:05
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 644b379
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636129b186104700087e680f
😎 Deploy Preview https://deploy-preview-12411--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 644b379
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636129b1a16f57000887c064
😎 Deploy Preview https://deploy-preview-12411--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[a11y] Text area: character count should be announced/read
4 participants