Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(containedlist): move to stable - add vrt, avt, storybook docs #12387

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 25, 2022

Closes #12319

Final steps to mark ContainedList as stable

Changelog

New

  • Component has an mdx document that follows our outline
  • mdx document provides a prop table
  • Component is tested via VRT for all stories
  • Component is tested via AVT for the initial render state
  • Added platform metadata carbon.yml, added live demo .mdx

Changed

  • Move story file out of /next
  • Move story out from under Experimental to Components section
  • Hide action, children, className from all stories' controls pane

Removed

  • unstable_ prefix from ContainedList

Testing / Reviewing

  • View all stories, ensure they render and function correctly
  • Make sure exports look correct - unstable_ prefix should be gone from both ContainedList and ContainedListItem

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 3873b94
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6363cd3e84345e000895bf7d
😎 Deploy Preview https://deploy-preview-12387--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3873b94
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6363cd3e7d8d93000869b4f5
😎 Deploy Preview https://deploy-preview-12387--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones self-assigned this Oct 25, 2022
@tay1orjones tay1orjones requested a review from janhassel October 25, 2022 14:46
Copy link
Member

@janhassel janhassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to having this component promoted to stable 👍

One question / comment: I noticed your removed the second list from both the "Default" and "Disclosed" story. The intent was to show their difference in spacing ("on page" having a top spacing if adjacent to another list while "disclosed" is flush). Do you think it would be worth to bring these back or does the Playground story cover this enough?

@tay1orjones
Copy link
Member Author

One question / comment: I noticed your removed the second list from both the "Default" and "Disclosed" story. The intent was to show their difference in spacing ("on page" having a top spacing if adjacent to another list while "disclosed" is flush). Do you think it would be worth to bring these back or does the Playground story cover this enough?

@janhassel Sorry, I totally missed this detail. I just pushed a commit bringing it back so the VRT will cover that styling and prevent regressions there.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kodiakhq kodiakhq bot merged commit f7ed5db into carbon-design-system:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move ContainedList, ContainedListItem to stable
4 participants