Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react): updated tile and stories #12312

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Oct 16, 2022

Closes #

#12315 along with playground stories

Changelog

Changed

  • Updated index to handle the new files vs the next ones

Removed

  • Removed args out of default

Testing / Reviewing

Storybook

@TannerS TannerS requested a review from a team as a code owner October 16, 2022 05:05
@TannerS TannerS requested review from tw15egan and jnm2377 October 16, 2022 05:05
@netlify
Copy link

netlify bot commented Oct 16, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 76bb0c3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6360279edbd1cc0009008357
😎 Deploy Preview https://deploy-preview-12312--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 16, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 76bb0c3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6360279e253e39000884eb84
😎 Deploy Preview https://deploy-preview-12312--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan
Copy link
Collaborator

@TannerS can we ensure each Tile has a unique id? There seem to be some issues when there are multiple Tile examples on the same page. To see the issue, go to the Radio with Layer story, as well as the docs tab and try and interact with select and then radio examples. I believe they are not updating because there are multiple duplicate id's on the same page. If you can get that working, we can also close this issue that just came in: #12315

@TannerS
Copy link
Contributor Author

TannerS commented Oct 26, 2022

updated

@TannerS
Copy link
Contributor Author

TannerS commented Oct 26, 2022

@TannerS can we ensure each Tile has a unique id? There seem to be some issues when there are multiple Tile examples on the same page. To see the issue, go to the Radio with Layer story, as well as the docs tab and try and interact with select and then radio examples. I believe they are not updating because there are multiple duplicate id's on the same page. If you can get that working, we can also close this issue that just came in: #12315

hey i looked into this, it appears some tiles (like radio) include this

export function useFallbackId(id) {
  const fallback = useId();
  return id ?? fallback;
}

so i cant do nothing about that, but let me manually set the ids

@TannerS
Copy link
Contributor Author

TannerS commented Oct 26, 2022

@tw15egan fixed the issue #12315, by adding new ids for components i playground

@tw15egan
Copy link
Collaborator

@TannerS looks good; the issue seems resolved 🎉

@TannerS
Copy link
Contributor Author

TannerS commented Oct 27, 2022

@TannerS looks good; the issue seems resolved 🎉

cool, anything else let me know

@tw15egan
Copy link
Collaborator

@TannerS any idea why there are snapshot changes in this PR?

@TannerS
Copy link
Contributor Author

TannerS commented Oct 27, 2022

@TannerS any idea why there are snapshot changes in this PR?

not a clue, tbh idk how snapshots work. I know i merged in main into this branch though

@kodiakhq kodiakhq bot merged commit 04a9186 into carbon-design-system:main Oct 31, 2022
@jsehull jsehull mentioned this pull request Mar 29, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants