Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): new icons request #12242

Merged
merged 7 commits into from
Oct 7, 2022

Conversation

conradennis
Copy link
Contributor

Submitting a few new requested UI icons
all updates and additions approved by BXD

4 net new icons

updated categories.yml with additions

Closes #12083

Changelog

New

  • watson-health/32/image-availability--local.svg
  • watson-health/32/image-availability--retrieving.svg
  • watson-health/32/image-availability--unavailable.svg
  • 32/plan.svg

Submitting a few new requested UI icons
all updates and additions approved by BXD

4 net new icons

updated categories.yml with additions
@conradennis conradennis requested review from laurenmrice and a team as code owners October 5, 2022 18:27
@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e1291f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63403ae5829afa00098b4ff2
😎 Deploy Preview https://deploy-preview-12242--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3e1291f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63403ae522d336000907592f
😎 Deploy Preview https://deploy-preview-12242--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@conradennis conradennis mentioned this pull request Oct 5, 2022
1 task
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! ✅

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conradennis I'm attempting to generate the metadata for this, but it looks like the file names might be incorrect? Instead of "image-", the file names include "imag-". Is this intentional?

@conradennis
Copy link
Contributor Author

@tay1orjones omg thanks for catching that. I was rushing and missed the "e". Just updated the file names

@tay1orjones tay1orjones requested a review from a team as a code owner October 7, 2022 13:00
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata has been generated and snaps have been updated 👍

@sstrubberg sstrubberg self-requested a review October 7, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature Request]: icons
5 participants