Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link component thumbnail svg #12218

Merged

Conversation

mattrosno
Copy link
Member

Closes carbon-design-system/carbon-platform#1278

Fixed thumbnail that shows a serif font in Safari.

Changelog

New

  • N/A

Changed

  • Link component thumbnail SVG

Removed

  • N/A

Testing / Reviewing

I opened the new SVG in Chrome to make sure the hover state will be good. Also, notice how the new SVG doesn't have <text> elements.

@mattrosno mattrosno requested a review from a team as a code owner October 3, 2022 18:02
@mattrosno mattrosno requested review from aledavila and jnm2377 October 3, 2022 18:02
@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cc23201
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/633c7e7a5cd5f90009ba8c38
😎 Deploy Preview https://deploy-preview-12218--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cc23201
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/633c7e7ab936250008f3e64a
😎 Deploy Preview https://deploy-preview-12218--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 541ced3 into carbon-design-system:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Outline all type in SVGs
3 participants