-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ProgressIndicator): fix focus style outline (#11773) #12213
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for contributing! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you!
cc @thyhmdo does this focus state look correct? |
Everything looks correct, except the Clicked state. |
Thank you all and thank you @thyhmdo for the spec! I can fix the :active state, so only 1px underline and $text-primary (#161616) token for the colors. |
Closes #11773
This fixes the ProgressIndicator focus style to follow the style guide.
Default
Focus when using keyboard
Hover
Clicked
Changelog
Changed
Removed
Testing / Reviewing