Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): render ellipsis when label is overflowing #12210

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

janhassel
Copy link
Member

Closes #11934

Changelog

New

  • Added text-overflow: ellipsis to listbox label

Testing / Reviewing

  • In the combobox story, select the first option ("An example option..."). Should truncate with ellipsis when the combobox is closed.
  • Note that when the combobox is opened, the label is a text input andshould therefore not truncate with ellipsis as the user can move the input caret.

@janhassel janhassel requested a review from a team as a code owner October 1, 2022 07:49
@janhassel janhassel requested review from aledavila and jnm2377 October 1, 2022 07:49
@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f31c1e5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/634040ff2ba1e800090aec07
😎 Deploy Preview https://deploy-preview-12210--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f31c1e5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/634040ffbb9ab700084b3d96
😎 Deploy Preview https://deploy-preview-12210--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sstrubberg sstrubberg enabled auto-merge (squash) October 7, 2022 14:57
@sstrubberg sstrubberg merged commit 056efd3 into carbon-design-system:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: ellipses do not show for truncated combobox selections
4 participants