Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(checkbox): update label headings #11860

Merged
merged 8 commits into from
Aug 9, 2022

Conversation

aledavila
Copy link
Contributor

Closes #11788

Updates labels for checkbox and radio button

Changelog

Testing / Reviewing

Make sure checkbox and radio buttons work as intended

@aledavila aledavila requested a review from a team as a code owner July 26, 2022 14:31
@aledavila aledavila requested review from tw15egan and jnm2377 July 26, 2022 14:31
@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 52d5d2a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62f2db1b8eb21700087be82d
😎 Deploy Preview https://deploy-preview-11860--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 52d5d2a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62f2db1b2820a9000857bdf1
😎 Deploy Preview https://deploy-preview-11860--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed an issue with the Radio Button Playground story

Screen Shot 2022-08-01 at 3 54 09 PM

Also, should we update the radio button labels to say "Radio button label"?

@aledavila
Copy link
Contributor Author

@tw15egan could you review again please.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit aed0301 into carbon-design-system:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: update content in storybook for checkbox and radiobutton
5 participants