fix(structured-list): change role of structured list #11448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dakahn
approved these changes
May 20, 2022
|
bump @aledavila when you get a sec! |
aledavila
approved these changes
May 24, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
### Related Ticket(s) Closes carbon-design-system#9827 ### Description the `refBottom` needs to be compared to the `containerTop`, so that the menu sticks to the bottom of button Example (using local `yarn pack`: https://codesandbox.io/p/devbox/test-overflowmenu-t4slfp?file=%2F.codesandbox%2Ftasks.json%3A1%2C241 live demo: https://t4slfp-9000.csb.app/ ### Changelog **New** - {{new thing}} **Changed** - changed `refBottom` to a let and then equal `refBottom = refBottom - containerTop;` - ^ wondering if this can be cleaned up code wise, but testing locally with overflow-menu it seems successful **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the role of our structured list to
tableinstead ofgridChangelog
New
Changed
Removed
Testing / Reviewing