Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove workflows from v10 branch #11012

Merged
merged 1 commit into from
Mar 17, 2022
Merged

chore: remove workflows from v10 branch #11012

merged 1 commit into from
Mar 17, 2022

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Mar 17, 2022 •
edited
Loading

Ref #10879

This removes github action workflows from the v10 branch. Instead, v10 workflows will be updated/added to main. It appears there are outstanding problems with initiating workflows from non-default branches. https://github.uint.cloudmunity/t/workflow-files-only-picked-up-from-master/16129/53

Changelog

Removed

  • remove all workflows from v10 branch

Testing / Reviewing

  • We'll probably just have to use admin rights to merge this in since status checks will all fail.

@tay1orjones tay1orjones requested a review from a team as a code owner March 17, 2022 18:49
@tay1orjones tay1orjones requested review from joshblack and abbeyhrt and removed request for a team March 17, 2022 18:49
@tay1orjones tay1orjones added the version: 10 Issues pertaining to Carbon v10 label Mar 17, 2022
@tay1orjones
Copy link
Member Author

Next phase of this work is in #11013

@tay1orjones tay1orjones mentioned this pull request Mar 17, 2022
Merged
@tay1orjones tay1orjones merged commit a70974a into carbon-design-system:v10 Mar 17, 2022
@tay1orjones
Copy link
Member Author

It looks like I was wrong. None of the workflows are triggering for v10. I think we need to have them in the v10 branch in addition to main, #11021

@tay1orjones tay1orjones deleted the remove-workflows branch March 18, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉 version: 10 Issues pertaining to Carbon v10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tay1orjones @joshblack @abbeyhrt