fix(content): remove background color from .bx--content #10992
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 896716d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622fa4fbbdcfb900087b1d15 😎 Browse the preview: https://deploy-preview-10992--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 896716d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622fa4fb5326a9000800a73d 😎 Browse the preview: https://deploy-preview-10992--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 896716d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622fa4fb4a457b0009f03085 😎 Browse the preview: https://deploy-preview-10992--carbon-components-react.netlify.app |
|
@aagonzales you were part of the issue discussions, so I requested your review. Is it ok to remove this background-color token for |
|
Yes, I remember now. The content area didn't span the full available area so was causing confusion. I'm good with removing the background color if it doesn't effect anything else. Is it used anywhere else?
|
@aagonzales not to my knowledge. The changes are isolated to the ui shell styles. |
|
I've changed the base branch to be |
Mirroring the change from #10992 in `v10` to `main` for v11.
|
cc @tay1orjones or @dakahn, when you get a sec could you help out with the snapshots failing for the test job? |
|
@joshblack I'm confused why the check is failing. I've pushed up the correct snap. Working off this PR locally there are no changes to commit from |
|
Sorry for the delay on this one. We had some issues with workflow config that caused the invalid snapshot problem. This will be included in v10.56.0, which should go out today. |
Mirroring the change from #10992 in `v10` to `main` for v11. Co-authored-by: Alessandra Davila <aledavila@ibm.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Fixes #9877
This PR removes the background color for the
.bx--contentselector, which is used by theContentcomponent.Changelog
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}