Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dep): include missing dep, small grid fix #10962

Merged
merged 4 commits into from
Mar 11, 2022
Merged

fix(dep): include missing dep, small grid fix #10962

merged 4 commits into from
Mar 11, 2022

Conversation

tay1orjones
Copy link
Member

Closes #10961

Hotfix that I'll publish a patch release for immediately following this being merged.

Changelog

New

  • Include the window-or-global dep that we use but was missing from the dependency tree

Changed

  • Correct the grid scss module path for breakpoint usage

Testing / Reviewing

  • window-or-global should be included in the appropriate dep tree
  • grid scss should compile

@tay1orjones tay1orjones requested a review from a team as a code owner March 11, 2022 14:00
@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7944785

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622b6afdd0ede400085c7f36

😎 Browse the preview: https://deploy-preview-10962--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7944785

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622b6afd3cbdc300084607b9

😎 Browse the preview: https://deploy-preview-10962--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 11, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 7944785

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622b6afdfed7b10008cbf46a

😎 Browse the preview: https://deploy-preview-10962--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 6e34a1a into carbon-design-system:main Mar 11, 2022
tay1orjones added a commit to tay1orjones/carbon that referenced this pull request Mar 11, 2022
@tay1orjones @tw15egan
fix(dep): include missing dep, small grid fix (carbon-design-system#1…
d5ebf7b 
…0962)

* fix(dep): include missing dep, small grid fix

* fix(grid): proper config for grid breakpoints and config

Co-authored-by: TJ Egan <tw15egan@gmail.com>
@tay1orjones tay1orjones mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Module not found: Can't resolve 'window-or-global' in .. carbon-components-react\es\internal
3 participants
@tay1orjones @joshblack @tw15egan