Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover color for icons on danger button (invisible icon when hovering) #792

Closed
vpavin opened this issue May 18, 2018 · 0 comments
Closed

Hover color for icons on danger button (invisible icon when hovering) #792

vpavin opened this issue May 18, 2018 · 0 comments
Assignees
@alisonjoseph

Comments

@vpavin
Copy link

vpavin commented May 18, 2018

Detailed description

SVG icons on danger button does not change fill to inverse color when hovering.
Color must be inverted to white fill as on secondary button in order to maintain icon visible.

Steps to reproduce the issue

  1. Hover on a danger button with icon

Additional information

1
@alisonjoseph alisonjoseph self-assigned this May 18, 2018
@alisonjoseph alisonjoseph mentioned this issue May 18, 2018
Merged
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@asudoh @joshblack
fix(OverflowMenu): prevent scroll-into-view behavior upon focus manag…
2a66ee5 
…ement (carbon-design-system#813)

* fix(OverflowMenu): prevent scroll-into-view behavior upon focus management

This change will ensure that focusing on overflow menu body happens after it's fully shown,
and focusing back on the trigger button does not happen when user clicks on another trigger button.

Fixes carbon-design-system#792.

* chore(OverflowMenu): avoid new polyfill introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonjoseph alisonjoseph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alisonjoseph @vpavin