Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max width grid does not appear centred on screen #546

Closed
gindik opened this issue Feb 7, 2018 · 2 comments · Fixed by #747
Closed

Max width grid does not appear centred on screen #546

gindik opened this issue Feb 7, 2018 · 2 comments · Fixed by #747

Comments

@gindik
Copy link

gindik commented Feb 7, 2018 •
edited
Loading

Within the grid system: http://carbondesignsystem.com/style/grid/design

The option to restrict the width of the grid to 1600px by using the "max" class results in the grid being shifted to the left.

The issue can be seen/explored here: https://codepen.io/gabrielindik/pen/jZMKxX
@tw15egan
Copy link
Contributor

tw15egan commented Feb 7, 2018

As a workaround, you can just add margin: 0 auto to the .max class

@alisonjoseph
Copy link
Member

I think you want to only add the margin: 0 auto at the largest breakpoint, otherwise you lose the 5% margin on the left/right at smaller screen sizes.

@joshblack joshblack mentioned this issue May 4, 2018
Merged
@unidevel unidevel mentioned this issue Dec 12, 2018
Closed
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@loganmccaul @tw15egan
All images, or role=img, including SVGs need to have an alt tag (carb…
83adc42 
…on-design-system#546)

* All images, or role=img, including SVGs need to have an alt tag

Although I disagree with this one because the title element is used by screen readers as the descriptor of svg's according to w3

```In order for elements with a role of img be perceivable, authors MUST provide alternative text or a label determined by the accessible name calculation.```

https://www.w3.org/TR/wai-aria/roles#img

* test: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(grid): center grid at largest breakpoint joshblack/carbon
3 participants
@alisonjoseph @tw15egan @gindik