-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Number input] control update #5417
Comments
I like A B C
|
Yeah I was wondering about that too. ^^ I notice the mobile version also does not include the invalid icon. Wasn't sure where to put that other than outside of the field. Looked wonky inside or attached on the outside. |
Yeah I agree, we could always render the error icon next to the error text 🤷♂ |
The input alignment could get weird with B if in a form if we want it to have some sort of text alignment. We would prob have to center the input text, and even if we left aligned it, it would never really align with anything because there is a button on the left. Kind of thinking C is the best option with full rule lines and is less fussy than A with the shorter rules. (however i know the fluid inputs have a smaller rule because the label is in the field) |
Makes sense to me 👍 |
Original prompt:
![image](https://user-images.githubusercontent.com/11670886/75064939-7bb8b780-54ad-11ea-8562-d2aa2976ee5a.png)
Explore other control options besides the up/down carets.
Final decision:
#5417 (comment)
The text was updated successfully, but these errors were encountered: