Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dropdown] size variants need to have same size drawer items #5070

Closed
laurenmrice opened this issue Jan 16, 2020 · 1 comment · Fixed by #5128
Closed

[dropdown] size variants need to have same size drawer items #5070

laurenmrice opened this issue Jan 16, 2020 · 1 comment · Fixed by #5128
Labels
component: dropdown type: enhancement 💡

Comments

@laurenmrice
Copy link
Member

The three different size variants should have the same size drawer items as they do for the top input field.

Also XL size isnt working in react.

Spec:
Screen Shot 2020-01-16 at 10 56 24 AM
@asudoh
Copy link
Contributor

asudoh commented Jan 16, 2020

Thank you for entering @laurenmrice - The XL size (of the trigger button) was fixed in #4928.

@asudoh asudoh mentioned this issue Jan 16, 2020
Closed
asudoh added a commit to asudoh/carbon-components that referenced this issue Jan 22, 2020
@asudoh
fix(list-box): fix dropdown item sizes
7ec51a7 
Fixes carbon-design-system#5070.
@asudoh asudoh mentioned this issue Jan 22, 2020
Merged
tw15egan added a commit that referenced this issue Jan 22, 2020
@asudoh @tw15egan
fix(list-box): fix dropdown item sizes (#5128)
2975d56 
Fixes #5070.

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dropdown type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list-box): fix dropdown item sizes asudoh/carbon-components
2 participants
@asudoh @laurenmrice