Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider is not working propably when set min to a non-zero value #349

Closed
kiddove opened this issue Oct 6, 2017 · 0 comments
Closed

Slider is not working propably when set min to a non-zero value #349

kiddove opened this issue Oct 6, 2017 · 0 comments

Comments

@kiddove
Copy link

kiddove commented Oct 6, 2017

Hi there,

I'm using the Slider component. I copied the code from the Carbon Design System site(http://www.carbondesignsystem.com/components/slider/live). When I changed the min value to 1, it's not working correctly. For instance, if I set min to 1 and set max to 3. I suspect that when I clicked on some place near the middle of the slider, it should changed into 2, and the thumb will go to the middle position. The dragging of the thumb is not working correctly either.

image
@aagonzales aagonzales added the bug label Nov 2, 2017
asudoh added a commit to asudoh/carbon-components that referenced this issue Nov 14, 2017
@asudoh
fix(slider): fix logic to calculate new left position and new value
b41297c 
There was an error in logic happening when min value is non-zero.

Fixes carbon-design-system#349.
@asudoh asudoh mentioned this issue Nov 14, 2017
Merged
asudoh added a commit to asudoh/carbon-components that referenced this issue Nov 14, 2017
@asudoh
fix(slider): fix logic to calculate new left position and new value
3776d84 
There was an error in logic happening when min value is non-zero.

Fixes carbon-design-system#349.
tw15egan pushed a commit that referenced this issue Nov 14, 2017
@asudoh @tw15egan
fix(slider): fix logic to calculate new left position and new value (#…
889e75e 
…429)

There was an error in logic happening when min value is non-zero.

Fixes #349.
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@nsand @sam1463
Default the OverflowMenu to have a tabindex of 0. Fixes carbon-design…
b69f65b 
…-system#348 (carbon-design-system#349)
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@ehdsouza @tw15egan
Added isExpanded prop in InteriorLeftNavList (carbon-design-system#349)
d93246d 
* fix(fix): Added accordion prop in InteriorLeftNav

For the InteriorLeftNav we need accordion behaviour where we want the child lists to be kept opened
unless closed by the user. This fixes
https://github.com/carbon-design-system/carbon-components-react/issues/328

fixes https://github.com/carbon-design-system/carbon-components-react/issues/328

* fix(fix): renamed isAccordion to isExpanded

Rename isAccordion to isExpanded according to review comments

https://github.com/carbon-design-system/carbon-components-react/issues/328

* fix(InteriorLeftNavList): Added isExpanded props to InteriorLeftNavList instead of parent

Added isExpanded props to InteriorLeftNavList instead of parent
joshblack added a commit to joshblack/carbon that referenced this issue May 8, 2019
@joshblack
feat(colors): update namespace and docs (carbon-design-system#349)
c7b986f 
* chore: check-in work

* feat(colors): update namespace and docs

* test(colors): update test setup

* chore: remove un-used section in README

* feat(colors): add support for stable map

* chore(format): run format

* chore: ignore prettier in block as it has a bug
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kiddove @aagonzales