-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notification] Update low contrast styling #2927
Comments
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
@shixiedesign Just wanted to double-check if we have any remaining work items in this space - Thanks! |
Hi @asudoh there are still several design updates outstanding with low contrast. At a glance, these are what I noticed: Inline low contrast notificationsThe Inline low contrast in vanilla is actually showing Toast, so I cannot review inline low contrast notifications: Toast low contrast notificationsClearly broken here, and I realize the issue might be on tokens. If any developers have bandwidth, we can have a quick chat about how this can be made. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
I believe it's fixed by #3899. @shixiedesign Please don't hesitate to speak up otherwise - Thanks! |
Design spec done. Ready for dev:
Please note: low contrast notification on light themes have an outline. The color of the outline is
$support-01 – $support-04
at30% opacity
. On dark themes they do not have outlines.Tokens
$support
at 0.3 opacity$field-01
$field-01
The text was updated successfully, but these errors were encountered: