Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Update low contrast styling #2927

Closed
shixiedesign opened this issue Jun 4, 2019 · 7 comments
Closed

[Notification] Update low contrast styling #2927

shixiedesign opened this issue Jun 4, 2019 · 7 comments
Labels
package: components carbon-components role: dev 🤖 status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Jun 4, 2019

Design spec done. Ready for dev:

Please note: low contrast notification on light themes have an outline. The color of the outline is $support-01 – $support-04 at 30% opacity. On dark themes they do not have outlines.

Tokens

Light themes Dark themes
outline $support at 0.3 opacity none
background $field-01 $field-01

Low contrast notifications

image

@shixiedesign shixiedesign self-assigned this Jun 4, 2019
@shixiedesign shixiedesign removed their assignment Jun 27, 2019
@shixiedesign shixiedesign changed the title [Notification] Secondary styling spec [Notification] Low contrast styling spec Jun 27, 2019
@shixiedesign shixiedesign changed the title [Notification] Low contrast styling spec [Notification] Update low contrast styling Jun 27, 2019
@stale
Copy link

stale bot commented Jul 27, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 27, 2019
@shixiedesign
Copy link
Contributor Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jul 29, 2019
@stale
Copy link

stale bot commented Aug 30, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 30, 2019
@asudoh
Copy link
Contributor

asudoh commented Aug 31, 2019

@shixiedesign Just wanted to double-check if we have any remaining work items in this space - Thanks!

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 31, 2019
@shixiedesign
Copy link
Contributor Author

shixiedesign commented Sep 3, 2019

Hi @asudoh there are still several design updates outstanding with low contrast. At a glance, these are what I noticed:

Inline low contrast notifications

The Inline low contrast in vanilla is actually showing Toast, so I cannot review inline low contrast notifications:

image

Toast low contrast notifications

Clearly broken here, and I realize the issue might be on tokens. If any developers have bandwidth, we can have a quick chat about how this can be made.

image

@stale
Copy link

stale bot commented Oct 3, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Oct 3, 2019
@asudoh
Copy link
Contributor

asudoh commented Oct 3, 2019

I believe it's fixed by #3899. @shixiedesign Please don't hesitate to speak up otherwise - Thanks!

@asudoh asudoh closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: components carbon-components role: dev 🤖 status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

2 participants