[Bug]: FormGroup lost disabled attribute in Carbon 11

[wkeese]

Package

@carbon/react

Browser

Chrome

Package version

1.62.1

React version

18

Description

In Carbon 10, FormGroup had a disabled attribute. In Carbon 11 (@carbon/react V1), it does not.

Since fieldset has a disabled attribute, and FormGroup is just a fieldset, then FormGroup should have a disabled attribute too.

Reproduction/example

https://stackblitz.com/edit/vitejs-vite-pwka1x?file=package.json

Steps to reproduce

I didn't have much luck reproducing this on Stackblitz. If there's a working example with Typescript and Carbon then I'd be happy to modify it to reproduce the error.

Suggested Severity

None

Application/PAL

IKC

Code of Conduct

• I agree to follow this project's Code of Conduct
• I checked the current issues for duplicate problems

[wkeese]

FYI, some research on the underlying problem:

Carbon 10 had the correct declaration (provided through @types/carbon-components-react):

export interface FormGroupProps extends React.FieldsetHTMLAttributes<HTMLFieldSetElement> {

whereas Carbon 11 is essentially doing

export interface FormGroupProps extends React.HTMLAttributes<HTMLFieldSetElement> {

So the difference is FieldsetHTMLAttributes vs HTMLAttributes.

One might think that HTMLAttributes<T> returns all the attributes of T, but it actually only returns a hardcoded list of attributes that apply to all HTML elements.

ReactAttr<HTMLFieldSet> --> HTMLAttributes<HTMLFieldSet> --> DOMAttributes<HTMLFieldSet> —> hardcoded list of attributes.

So I guess extending React.FieldsetHTMLAttributes<HTMLFieldSetElement> would have been a better strategy to fix this. It's what Carbon 11 does for TextInput:

export interface TextInputProps
  extends Omit<
    React.InputHTMLAttributes<HTMLInputElement>,
    ExcludedAttributes
  > {