Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: violate HTML specification for tiles #15607

Closed
2 tasks done
captainkovalsky opened this issue Jan 25, 2024 · 2 comments · Fixed by #15610
Closed
2 tasks done

[Bug]: violate HTML specification for tiles #15607

captainkovalsky opened this issue Jan 25, 2024 · 2 comments · Fixed by #15610
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. severity: 4 https://ibm.biz/carbon-severity status: help wanted 👐 type: bug 🐛

Comments

@captainkovalsky
Copy link

Package

@carbon/react

Browser

No response

Package version

11

React version

No response

Description

Non HTML Semantic issue for Tiles

Reproduction/example

https://react.carbondesignsystem.com/?path=/docs/components-tile--overview

Steps to reproduce

Inspect HTML output

https://react.carbondesignsystem.com/?path=/docs/components-tile--overview

div is inside span

image

Suggested Severity

Severity 4 = Unrelated to a user task, has a workaround or does not need a workaround.

Application/PAL

No response

Code of Conduct
@captainkovalsky captainkovalsky changed the title [Bug]: [Bug]: Incorrect HTML for tiles Jan 25, 2024
@captainkovalsky captainkovalsky changed the title [Bug]: Incorrect HTML for tiles [Bug]: violate HTML specification for tiles Jan 25, 2024
@tay1orjones tay1orjones added the severity: 4 https://ibm.biz/carbon-severity label Jan 26, 2024
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jan 26, 2024
@tay1orjones tay1orjones added status: help wanted 👐 good first issue 👋 Used by GitHub to elevate contribution opportunities needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Jan 26, 2024
@tay1orjones
Copy link
Member

Yep, needs to be changed to a div. Once changed, the associated display: block styling for that element can be removed, but we'll need to leave the classname on there so folks don't see a regression if they're testing or using that selector for override styling in their apps.

PRs are open if you or anyone else would be willing to submit a fix, thanks for reporting this!

@imshubs24 imshubs24 mentioned this issue Jan 26, 2024
Merged
@imshubs24
Copy link
Contributor

Hi @tay1orjones, I tried to fix the issue as you suggested, I am new to open-source contribution I hope i fixed it.

github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2024
@imshubs24 @andreancardona @tw15egan
Fix #15607: Replaced <span> with <div>, Removed unnecessary styling (#…
56d82b5 
…15610)

* Fix #15607: Replaced <span> with <div>, Removed unnecessary styling of that block

* fix(Tile): adjust types, fix below the fold span

---------

Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. severity: 4 https://ibm.biz/carbon-severity status: help wanted 👐 type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #15607: Replaced <span> with <div>, Removed unnecessary styling
3 participants
@captainkovalsky @tay1orjones @imshubs24